Bug 37430 - girar-task-approve email message change request
Summary: girar-task-approve email message change request
Status: NEW
Alias: None
Product: Infrastructure
Classification: Infrastructure
Component: girar (show other bugs)
Version: unspecified
Hardware: all Linux
: P3 normal
Assignee: placeholder@altlinux.org
QA Contact: Andrey Cherepanov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-06 10:30 MSK by Олег Соловьев
Modified: 2021-07-30 17:32 MSK (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Олег Соловьев 2019-11-06 10:30:19 MSK
I don't like the double "of" in the message.

-X has added an approval of subtask #YYY of task #ZZZZZZ
+X has added an approval for subtask #YYY of task #ZZZZZZ
Comment 1 Dmitry V. Levin 2019-11-06 12:09:53 MSK
(In reply to comment #0)
> I don't like the double "of" in the message.
> 
> -X has added an approval of subtask #YYY of task #ZZZZZZ
> +X has added an approval for subtask #YYY of task #ZZZZZZ

"added an approval for subtask" wouldn't be grammatically correct.
The only alternative I could think of is

X has given an approval to subtask #YYY of task #ZZZZZZ

but what about revocations?
Comment 2 Олег Соловьев 2019-11-06 12:13:53 MSK
(В ответ на комментарий №1)
> X has given an approval to subtask #YYY of task #ZZZZZZ
> 
> but what about revocations?

X has revoked/cancelled an approval to subtask #YYY of task #ZZZZZZ?
Comment 3 Dmitry V. Levin 2021-07-30 03:17:43 MSK
(In reply to Олег Соловьев from comment #2)
> (В ответ на комментарий №1)
> > X has given an approval to subtask #YYY of task #ZZZZZZ
> > 
> > but what about revocations?
> 
> X has revoked/cancelled an approval to subtask #YYY of task #ZZZZZZ?

You can "give to", but you cannot "revoke to".  This would have to be smth like
"X has revoked the approval that was given to subtask #YYY of task #ZZZZZZ"
which is somewhat lengthy.
Comment 4 Олег Соловьев 2021-07-30 10:37:16 MSK
(In reply to Dmitry V. Levin from comment #3)
> (In reply to Олег Соловьев from comment #2)
> > (В ответ на комментарий №1)
> > > X has given an approval to subtask #YYY of task #ZZZZZZ
> > > 
> > > but what about revocations?
> > 
> > X has revoked/cancelled an approval to subtask #YYY of task #ZZZZZZ?
> 
> You can "give to", but you cannot "revoke to".  This would have to be smth
> like
> "X has revoked the approval that was given to subtask #YYY of task #ZZZZZZ"
> which is somewhat lengthy.

"X has revoked the approval from subtask #YYY of task #ZZZZZZ"

If it is still lengthy we can write something like "task #ZZZZZZ:YYY"
Comment 5 Ivan Zakharyaschev 2021-07-30 17:32:43 MSK
(Ответ для Олег Соловьев на комментарий #0)
> I don't like the double "of" in the message.
> 
> -X has added an approval of subtask #YYY of task #ZZZZZZ
> +X has added an approval for subtask #YYY of task #ZZZZZZ

Personally, I don't see anything awful in a sequence of "of" in a language such as English (contrary to Russian), which has lost most inflection (cases), similarly to French. (Modern English grammar resulted from the pressure of French, which was spoken by the noble men after the Norman conquest.) Compare a sequence of "de" in French, which raises no stylistic questions -- https://fr.wikipedia.org/wiki/RPM_Package_Manager :

RPM est un système de gestion de paquets de logiciels
RPM is  a  system  of management of packages of software

* * *

As for the prepositions that "approval" can govern, I found some more examples, showing the use of "for", "of", and "on":

https://en.wiktionary.org/wiki/approval#Noun :

    I need to get an approval on this purchase order.

https://www.oxfordlearnersdictionaries.com/definition/english/approval?q=approval :

     approval of something The government is seeking approval of its plans.
    The proposal is subject to approval by the shareholders (= they need to agree to it).

    approval for something from somebody They required/received approval for the proposal from the shareholders.

    approval for something He won approval for his project.

    approval from somebody He left without obtaining the necessary approval from the authorities.
    She expects to gain final approval from the council.

Extra Examples

    The committee is expected to recommend approval of the new drug.
    The government has now given its approval for the new examinations.
    The scheme did not meet unqualified approval.
    We already have approval for six products.
    We have submitted a design for approval.
    You may not decorate the flat without the landlord's approval.
    Alterations to the hotel must have planning approval.
    The measure would require the approval of the European Parliament.
    The treaty still required approval by the Senate.
    The winning photo will be published in the magazine, subject to the Editor's approval.