Bug 34559 - gtkprintbackendcups.c: fix \n at end of a debugging note
Summary: gtkprintbackendcups.c: fix \n at end of a debugging note
Status: NEW
Alias: None
Product: Sisyphus
Classification: Development
Component: libgtk+2 (show other bugs)
Version: unstable
Hardware: all Linux
: P3 minor
Assignee: Yuri N. Sedunov
QA Contact: qa-sisyphus
URL: https://gitlab.gnome.org/GNOME/gtk/me...
Keywords:
Depends on: 34560
Blocks:
  Show dependency tree
 
Reported: 2018-02-17 21:48 MSK by Ivan Zakharyaschev
Modified: 2018-02-17 21:53 MSK (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Zakharyaschev 2018-02-17 21:48:00 MSK 
2.24.32-alt2

Without the newline in the debugging message, there is a mess because two messages get into the same line, as it was for me in https://bugzilla.gnome.org/show_bug.cgi?id=793529 .

https://gitlab.gnome.org/GNOME/gtk/merge_requests/23/diffs?commit_id=7461ceebe34bfc6f882145e89e1ba2f187d08303 :

diff --git a/modules/printbackends/cups/gtkprintbackendcups.c b/modules/printbackends/cups/gtkprintbackendcups.c
index 24d4d8b..2a000dc 100644
--- a/modules/printbackends/cups/gtkprintbackendcups.c
+++ b/modules/printbackends/cups/gtkprintbackendcups.c
@@ -2184,7 +2184,7 @@ cups_printer_handle_attribute (GtkPrintBackendCups *cups_backend,
   else
     {
       GTK_NOTE (PRINTING,
-		g_print ("CUPS Backend: Attribute %s ignored", ippGetName (attr)));
+		g_print ("CUPS Backend: Attribute %s ignored\n", ippGetName (attr)));
     }
 
 }