Bug 27364 - [PATCH] Имя недостающей перловой зависимости урезается до слеша
Summary: [PATCH] Имя недостающей перловой зависимости урезается до слеша
Status: CLOSED FIXED
Alias: None
Product: Sisyphus
Classification: Development
Component: apt (show other bugs)
Version: unstable
Hardware: all Linux
: P3 normal
Assignee: placeholder@altlinux.org
QA Contact: qa-sisyphus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-24 16:36 MSK by viy
Modified: 2012-05-24 22:16 MSK (History)
5 users (show)

See Also:


Attachments
simple patch that work (426 bytes, patch)
2012-05-24 17:19 MSK, viy
no flags Details | Diff
extended patch (685 bytes, patch)
2012-05-24 17:21 MSK, viy
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description viy 2012-05-24 16:36:18 MSK
При сборке в hasher имена недостающих перловых зависимостей нечитабельны:
Вместо полных имен вида perl(Test/BlaBla.pm) печатается
E: Couldn't find package perl(Test
Comment 1 viy 2012-05-24 17:16:41 MSK
Быстрый patch, который помог - было 
E: Couldn't find package perl(Test
стало
E: Couldn't find package perl(Test/More.pm)>=0.01

№------------------------------------
--- a/apt/cmdline/apt-get.cc
+++ b/apt/cmdline/apt-get.cc
@@ -1995,7 +1995,7 @@ bool DoInstall(CommandLine &CmdL)
            if (Hit == true)
               continue;
 #endif
-           return _error->Error(_("Couldn't find package %s"),S);
+           return _error->Error(_("Couldn't find package %s"),OrigS);
         }
 
         // Regexs must always be confirmed
№------------------------------------
В коде 2 сообщения Невозможно найти пакет...
возможно, имеет смысл запатчить оба, как в расширенном патче внизу.
--- a/apt/cmdline/apt-get.cc
+++ b/apt/cmdline/apt-get.cc
@@ -1995,7 +1995,7 @@ bool DoInstall(CommandLine &CmdL)
            if (Hit == true)
               continue;
 #endif
-           return _error->Error(_("Couldn't find package %s"),S);
+           return _error->Error(_("Couldn't find package %s"),OrigS);
         }
 
         // Regexs must always be confirmed
@@ -2034,7 +2034,7 @@ bool DoInstall(CommandLine &CmdL)
         regfree(&Pattern);
         
         if (Hit == false)
-           return _error->Error(_("Couldn't find package %s"),S);
+           return _error->Error(_("Couldn't find package %s"),OrigS);
       }
       else
       {
Comment 2 viy 2012-05-24 17:19:01 MSK
Created attachment 5470 [details]
simple patch that work

simple patch that work
Comment 3 viy 2012-05-24 17:21:52 MSK
Created attachment 5471 [details]
extended patch

Расширенный патч.
Там два места, где выводится сообщение, 
по идее оба надо пропатчить.
Comment 4 viy 2012-05-24 17:23:05 MSK
Прошу приложить предложенный патч.
Comment 5 Repository Robot 2012-05-24 22:11:50 MSK
apt-0.5.15lorg2-alt41 -> sisyphus:

* Thu May 24 2012 Dmitry V. Levin <ldv@altlinux> 0.5.15lorg2-alt41
- apt-get, apt-shell: when a package could not be found, print the
  unmangled package request string (by Igor Vlasenko; closes: #27364).
- apt-shell: do not abort when commit is cancelled (closes: #13877);
  Unlike one may suppose, this change will not cause the cache of
  accumulated changes to be cleared by cancelled "commit" operation, but
  this is exactly what Vitaly Lipatov has proposed in his comments to #13877.
Comment 6 viy 2012-05-24 22:16:03 MSK
Thanks!